Repository navigation
cuda: keep the extended tall mat-vec types off fused gate+up launches - #419
Merged
Merged
Conversation
The 8-rows-per-CTA geometry for Q8_0/Q4_0/Q2_0/Q4_K/Q6_K helps plain one-column mat-vecs but costs time on fused gate+up pairs. Leave those on the default geometry; PQ2_0 keeps its existing behavior. Output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
should_use_tall: extended types are tall only whenfusion.gate == nullptr. The K partition and reduction order do not change, so output is identical.Testing